allowUnfree and overlays #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9698a12
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4c7ded5.devenv.pages.dev |
| Branch Preview URL: | https://unfree-and-overlays.devenv.pages.dev |
domenkozar
force-pushed
the
unfree-and-overlays
branch
from
3c85acb
to
4430eb1
Compare
domenkozar
force-pushed
the
unfree-and-overlays
branch
from
d270660
to
ec1b9d0
Compare
domenkozar
force-pushed
the
unfree-and-overlays
branch
from
ec1b9d0
to
b0f22d7
Compare
shyim
approved these changes
Feb 9, 2023
|
Will this need that the user update devenv on their machine or is it enough that youre modules update |
|
You'll need to update devenv :) |
|
Works great for me! @domenkozar have you thought about the UX of this? e.g. if someone tries to use this feature with an older version, can we nudge them towards an update? I guess that'd have to be a generic "couldn't parse config, maybe you need to update?" message. |
|
I was thinking about the UX. Now that we use strictyaml for validation we can do this and nudge people to upgrade. I'm also thinking to add a field like |
|
Moved the scope for the UX into #388 |
kubukoz
approved these changes
Feb 10, 2023
|
|
domenkozar
force-pushed
the
unfree-and-overlays
branch
from
4a9dba6
to
a0e1ad3
Compare
hugosenari
reviewed
Feb 13, 2023
Co-authored-by: Hugo Sena Ribeiro <[email protected]>
hugosenari
reviewed
Feb 13, 2023
hugosenari
reviewed
Feb 13, 2023
Co-authored-by: Hugo Sena Ribeiro <[email protected]>
Draft
Co-authored-by: Hugo Sena Ribeiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154 #185
You can now do
devenv.yaml: